Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Swagger UI to the newest version #161

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

pavelhoral
Copy link
Member

This PR upgrades Swagger UI to fix dependency alerts. The UI itself works, however the request made by the UI are not rendered because the Swagger definition file contain errors... but that is issue of the API definition itself and potentially an issue with API Descriptor library from wrensec-commons.

Also the latest Swagger UI release is unbelievably slow... this is an issue with Swagger UI itself (swagger-api/swagger-ui#6787) and hopefully will be addressed soon-ish.

Copy link
Member

@karelmaxa karelmaxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@karelmaxa karelmaxa merged commit 5d44b4b into WrenSecurity:main Sep 26, 2023
2 checks passed
@karelmaxa karelmaxa deleted the upgrade-swagger branch September 26, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants